-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: xfce4 wallpaper not changing #22646
Comments
The similar issue has been reported in Discord but I can not reproduce it. Could you try to set things up from scratch - close xfce, move |
Is there any output in termux while changing wallpaper? |
@Biswa96 there is still a shadow between the panel and the wallpaper, and the wallpaper does not change. And while changing the wallpaper, Termux does not display anything separately. |
@Biswa96 Screen_Recording_20241222_040423_TermuxX11.mp4 |
|
@Biswa96 |
Correction: That was not an issue in my setup. I just did not double click it. So, I have not yet able to reproduce the issue. |
@Biswa96
And the https://github.com/termux/termux-x11/actions/runs/12447846023 |
Screen_Recording_20241222_060650_TermuxX11.mp4 |
Temporary fix until issue resolved properly here ... script will list available wallpapers allowing you to choose the one you want then apply it. You do need to restart termux for it to take affect. |
@hansm629 except for the panel's shadow, it's a feature, not a bug. |
@ar37-rs When the shadow appeared like that, it would disappear when you restarted xfce4, but now it doesn't at all. |
The bug was the shadow under docks disappearing ... sounds like the bug is resolved if it's staying this time. Go into compositor tab in window manager tweaks to remove shadows under dock windows if you want it gone. [EDIT] Can confirm, that particular bug seems resolved and shadows under dock windows is persistent between restarts now. I guess the trade off was losing ability to change wallpaper easily. |
@phoenixbyrd Which menu do I go into to turn off the shadows? |
@hansm629 |
Yea that's the one. |
@phoenixbyrd @FlipnotypicalRodent32 I just need to fix the issue of not being able to change the wallpaper! |
Previous xfce version wasn't displaying the shadow properly or consistently ... personally I disabled it so never bothered me. |
I’m glad we helped you! |
Until they update with a proper fix for the wallpaper issue you can always use the script posted earlier to get the job done. |
It does work for "custom" wallpapers, just make sure the wallpaper you want to use is moved to $PREFIX/usr/share/backgrounds/xfce first. Or if you have a different location just change it to that in the script to list the wallpapers you want to use. |
Oh, ok. |
heres the logs i got while restarting xfdesktop in debug mode maybe it would help
|
for changing backgrounds
|
--- xfdesktop-backdrop-manager-old.c 2024-12-22 21:43:20.548619193 +1100
+++ xfdesktop-backdrop-manager.c 2024-12-22 23:17:16.625594014 +1100
@@ -408,7 +408,7 @@
G_GNUC_END_IGNORE_DEPRECATIONS
return g_strdup_printf("/backdrop/screen%d/monitor%s/",
screen_num,
- monitor_get_identifier(monitor));
+ xfdesktop_remove_whitspaces(monitor_get_identifier(monitor)));
}
static gchar *
@@ -442,7 +442,7 @@
gchar *span_monitor_property_prefix = g_strdup_printf("/backdrop/screen%d/monitor%s/workspace%d",
screen_num,
- monitor_get_identifier(first_monitor),
+ xfdesktop_remove_whitspaces(monitor_get_identifier(first_monitor)),
workspace_num);
gchar *first_image_style_prop = g_strconcat(span_monitor_property_prefix, "/image-style", NULL);
XfceBackdropImageStyle first_image_style = xfconf_channel_get_int(manager->channel,
@@ -467,7 +467,7 @@
}
return g_strdup_printf("/backdrop/screen%d/monitor%s/workspace%d",
screen_num,
- monitor_get_identifier(the_monitor),
+ xfdesktop_remove_whitspaces(monitor_get_identifier(the_monitor)),
workspace_num);
}
}
--- xfdesktop-common-old.c 2024-10-14 23:11:52.000000000 +1100
+++ xfdesktop-common.c 2024-12-22 23:25:28.841593827 +1100
@@ -538,7 +538,7 @@
for (gint i = 0; i < n_workspaces; ++i) {
gchar *new_name = g_strdup_printf("/backdrop/screen%d/monitor%s/workspace%d/%s",
screen_num,
- monitor_name,
+ xfdesktop_remove_whitspaces(monitor_name),
i,
new_setting_name);
if (!xfconf_channel_has_property(channel, new_name)) {
@@ -582,7 +582,7 @@
for (gint i = 0; i < n_workspaces; ++i) {
gchar *new_name = g_strdup_printf("/backdrop/screen%d/monitor%s/workspace%d/image-style",
screen_num,
- monitor_name,
+ xfdesktop_remove_whitspaces(monitor_name),
i);
if (!xfconf_channel_has_property(channel, new_name)) {
xfconf_channel_set_int(channel, new_name, XFCE_BACKDROP_IMAGE_NONE);
@@ -671,7 +671,7 @@
for (gint i = 0; i < n_workspaces; ++i) {
gchar *new_name = g_strdup_printf("/backdrop/screen%d/monitor%s/workspace%d/%s",
screen_num,
- monitor_name,
+ xfdesktop_remove_whitspaces(monitor_name),
i,
setting_name);
if (!xfconf_channel_has_property(channel, new_name)) { working patch for now, i guess screen-20241222-232833.2.mp4 |
@Biswa96 should i make pr? not sure if it works for everyone/have any side effects tho |
Thank you for your thorough analysis of this issue. I am not sure about the change and shall ask about the issue in xfce community channels. In the meantime, please feel free to create a pull request for testing purposes. I would like to confirm this matter with the upstream developers as well. |
Some info from my setup. Monitor identifier changes in xfce if I start it with
|
it happened to be |
also for |
probably a bug of termux-x11, I'll take a look soon. |
alright then. |
I can reproduce it only in the case if you start termux-x11 with Termux:X11's activity not running in background or foreground. Did you switch to Termux:X11 before checking screen name and refresh rate? |
screen-20241223-024624.2.mp4like this, tho now i'm getting 30hz builtin display instead somehow tho same as how |
Try this one. Does it happen with this build? |
And it seems like you need to charge your device. |
still happening, but as usual the frame rate returned to the desired one after one screen resize |
Ok, it is very weird. |
this seems to happen only on for but for but it fixed itself back to a |
Ok, probably it clarifies the situation. Probably the server is being reset during |
Try this one. |
thats arm32, i can't install |
Sorry. This one. |
seems fixed, now |
The fix is merged to master. |
I'm affected too, but the only relevant log message appears to be this:
|
you can download the deb artifact in the pr checks |
(This is a pre-written, saved reply.) After downloading the build artifact, make sure to Detailed instructions, if needed.
# finding out what architecture you need
# architecture is just below the TERMUX_VERSION
termux-info
# e.g.
# [...]
# TERMUX_MAIN_PACKAGE_FORMAT=debian
# TERMUX_VERSION=0.118.0
# TERMUX__USER_ID=0
# Packages CPU architecture:
# aarch64
# [...]
# =======================
# make sure `unzip` and `tar` are installed using
pkg install unzip tar
# unzip the artifact (if you have a different architecture this might be arm, i686 or x86_64 instead)
unzip debs-aarch64-*.zip
# untar the artifact
tar xf debs-aarch64-*.tar
# You should now have a debs/ directory in your current working directory
# Install the packages from the local source using
pkg install -- ./debs/*.deb
# to clean up, you can remove the debs/ directory, .tar file and .zip file
rm -rfi debs debs-aarch64-*.zip debs-aarch64-*.tar |
Installed. This version works. I can change wallpaper now. However, |
I removed everything in |
Problem description
Since
xfce4
updated to the latest version,there is a shadow between the top panel and the wallpaper,and the wallpaper does not change at all.
What steps will reproduce the bug?
Screen_Recording_20241222_032612_TermuxX11.mp4
What is the expected behavior?
No response
System information
The text was updated successfully, but these errors were encountered: