Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfce4: fix wallpaper bug #22654

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

xfce4: fix wallpaper bug #22654

wants to merge 2 commits into from

Conversation

813ethan
Copy link
Contributor

A proposed fix for #22646

Back in xfce 4.14 there seems to be a patch that removed whitespaces from monitor names,

This knowledge seems to be lost as this refractor was commited recently in xfce 4.20pre1, as whitespaces removal in paths is not added.

Nonexistent paths like /backdrop/screen0/monitorBuiltin Display/workspace0 were given to the application, which lead to a failure for it to set/retrieve the wallpaper.

might be an upstream xfce4 issue, tho I am too lazy to file an issue there

@813ethan 813ethan changed the title xfdesktop: fix wallpaper bug fix(x11/xfdesktop): fix wallpaper bug Dec 22, 2024
@813ethan
Copy link
Contributor Author

@hansm629 @FlipnotypicalRodent32 @phoenixbyrd test?

@hansm629
Copy link

@813ethan
After installing the deb package, I restarted xfce4 and now the wallpaper changes properly!
Thank you!

@phoenixbyrd
Copy link

@hansm629 @FlipnotypicalRodent32 @phoenixbyrd test?

I'll give it a shot after work today but sounds like it's working now so I'm excited to try it!

@FlipnotypicalRodent32
Copy link

FlipnotypicalRodent32 commented Dec 22, 2024

@hansm629 @FlipnotypicalRodent32 @phoenixbyrd test?

Just tested it and it works fine now! So many thanks for fixing the bug!
Now let’s wait for @phoenixbyrd to test it.

@phoenixbyrd
Copy link

Sadly didn't seem to work for me, just gave me a white background that I couldn't change via any method. Had to revert back to previous version to set wallpaper again. I'll wait for an official update with pkg update and see if that does the trick then.

@FlipnotypicalRodent32
Copy link

Sadly didn't seem to work for me, just gave me a white background that I couldn't change via any method. Had to revert back to previous version to set wallpaper again. I'll wait for an official update with pkg update and see if that does the trick then.

Have you tried updating Termux:X11 to latest nightly release?

@813ethan
Copy link
Contributor Author

813ethan commented Dec 22, 2024

Sadly didn't seem to work for me, just gave me a white background that I couldn't change via any method. Had to revert back to previous version to set wallpaper again. I'll wait for an official update with pkg update and see if that does the trick then.

have you tried changing to other backgrounds in xfdesktop-settings? see if it works

or try to update Termux:X11 app to latest, there're some fixes on screen identifiers when using startxfce4 on recent update

@813ethan 813ethan force-pushed the xfdesktop branch 2 times, most recently from 279ee0c to 68e99b2 Compare December 23, 2024 05:23
@813ethan 813ethan changed the title fix(x11/xfdesktop): fix wallpaper bug xfce4: fix wallpaper bug Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants