Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dependence on six #2037

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Removing dependence on six #2037

merged 1 commit into from
Dec 20, 2024

Conversation

john-science
Copy link
Member

What is the change?

Removing ARMI's direct dependence on six.

However, you will notice I didn't remove six from pyproject.toml, because it is not in there. One of ARMI's secondary dependencies is six, apparently. (I haven't bothered to figure out which one.)

Why is the change being made?

ARMI doesn't support Python 2 any more, so we don't need this dependence.

close #2036


Checklist

  • The release notes have been updated if necessary. (This doesn't require a release note.)
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science
Copy link
Member Author

john-science commented Dec 19, 2024

Okay, since this PR / ticket exists because we had a first-order dependency masquerading as a second-order dependency, I have gone through every import in ARMI to make sure they are included in our pyproject.toml file and otherwise make sense.

Here are the results:

  • armi/utils/parsing.py: from dateutil import parser
    • First-order dependency not in pyproject.toml!
  • armi/bookkeeping/tests/test_historyTracker.py: import nbformat
    • (also used in armi/tests/test_notebooks.py)
    • First-order dependency not in pyproject.toml!

Copy link
Contributor

@drewj-tp drewj-tp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@john-science john-science merged commit f528eee into main Dec 20, 2024
22 checks passed
@john-science john-science deleted the ditch_six branch December 20, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use of six module
2 participants