Initial restructure of image viewer, fixes some immedate bugs #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTalvio
added
the
on-hold
|
gonna investigate how this handles system padding (notches, softkeys etc.) |
CTalvio
removed
the
on-hold
|
Ok, the image viewer is now in a really good place I think. Not massively different but now it doesn't seem to suffer from any "quirks". |
disable edge-to-go-back on Android when full screen swipe gestures are disabled
…pp#1347) * OLED color theme and UI alignment fixes * Fix post editor community insert too * Oops, use name instead of title * Fix account page OLED colors * formatting and typo
* A number of improvements to notifications * Remove unnecessary column
* Improve gesture settings clarity * No shadows * Remove unneeded imports
* Update translation files Updated by "Cleanup translation files" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/ Translation: Thunder/Thunder * Translated using Weblate (Spanish) Currently translated at 99.2% (687 of 692 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (666 of 666 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (665 of 665 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (642 of 642 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (639 of 639 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (630 of 630 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (628 of 628 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (627 of 627 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (624 of 624 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (623 of 623 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (607 of 607 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (605 of 605 strings) Co-authored-by: gallegonovato <[email protected]> Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/es/ Translation: Thunder/Thunder * Translated using Weblate (Russian) Currently translated at 71.7% (447 of 623 strings) Co-authored-by: Evgeniy Khramov <[email protected]> Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/ru/ Translation: Thunder/Thunder * Translated using Weblate (Spanish) Currently translated at 100.0% (692 of 692 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/es/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/ * Translated using Weblate (Spanish) Currently translated at 100.0% (712 of 712 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/es/ * Translated using Weblate (Portuguese) Currently translated at 0.4% (3 of 712 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/pt/ * Translated using Weblate (Spanish) Currently translated at 100.0% (713 of 713 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/es/ --------- Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: gallegonovato <[email protected]> Co-authored-by: Evgeniy Khramov <[email protected]> Co-authored-by: Filipe Mota (BlackSpirits) <[email protected]>
Co-authored-by: GitHub <[email protected]>
* Fix FAB darkening transparency and exit animation * Fix FAB darkening transparency and exit animation * formatting
* Improve creating posts/comments * Remove unused selectable parameter * Improve appearance of post/comment reply controls * Add comments for clarity * Simplify viewSource parameter * Use container margin instead of padding * Refactor widget
… notification icon (thunder-app#1355)
* Improve the comment context jumping * Ensure a good minimum * Remove dependence on itemPositionsListener
…p#1361) replace scrollable_positioned_list with super_list
* New score single-side score indicator icon using stacked arrows * formatting
partially fixed issue where comment navigation was not respecting current user scroll position
…ation payload (thunder-app#1364) * Improve UnifiedPush notifications * Fix missing notification ID * Use slim payload object
* experimental support for video players. * init experimental support for video players * implement video players nav and players * init video player settings page * swap chewie for betterplayer (river_player), improve video settings page * network type in video player settings * yt player use thunder bloc for prefs * fix intl linters,video player page always black, formart modified,update changelog * rm unused audio permissions * resolve PR notes * play arrow in place of language icon compact view,default volume
* Move account button left, add account management to account settings * Do not show just saved or placeholder when actually still loading a profile * Change login instance links into buttons * formatting * Further improvements, localisation * Fix account page failing to update * Undo removal of returns in listeners * add logged-in check to reload check * do no restore previous user on account settings exit * formatting * absolute import
* improved image dimension logic, added video logic when parsing post views * added back button to video player, added snackbar when video fails to load * added button to open in browser, removed play icon from media view, misc fixes * fix media view UI inconsistencies * fixed various issues with compact and card view rendering * added mute functionality to youtube player, fixed video settings not applying immediately, fixed network connectivity checking * fix status bar not showing after full screen
mark post as read on video play
* feat: add url to condensed post view * feat: remove www from host in URL
…-app#1605) * feat: add option to toggle pure black mode when using system theme * feat: add localization string for searching system dark theme
* feat: add setting to automatically expand taglines * feat: use initialExpanded to determine expanded state
…hunder-app#1563) * Video Player preferences playing mode (InApp, InAppBrowser,External) * update use in-built player string * fix video player setting page formatting * chore: minor code adjustments for better readability --------- Co-authored-by: Hamlet Jiang Su <[email protected]>
* Fix system navbar color * Use FlexColorScheme to set the transparent nav bar
* Fix status bar color * Fix status bar color in pure dark mode * A different approach to fixing the status bar color
* Fix text hint color * Move theme styling
* refactor: remove go router dependency to allow for restorable routes * fix: fix setting linking not redirecting, linting * fix: fix deep links not redirecting properly
* refactor: migrate from uni_links to app_links * fix: fix deep link config for iOS, potential fix for 1575
* Allow navigating to modlog for removed comment * Remove comment modlog custom filtering * Only show comment modlog for 0.19.4+
fix: add libsqlite3 install for ci workflow
* chore: updated dependencies * upgraded packages to latest major versions
* fix: potentially fix issue with app hanging after update to v0.6.0-2 * chore: upgrade version for nightly
…ve_image_viewer # Conflicts: # lib/shared/image_viewer.dart
|
This should be back up to date and ready to merge. I also made it so that once downloading/downloaded, the save button becomes disabled. Used to accidentally save the same image twice at times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Starting work on the image viewer. Here is an initial take of on a refactor that works around some of the quirks of extendedimage.
I used a stack to make the image viewer widget the size of the screen, which seems to be the only way to avoid the bugs the current viewer is suffering from.
Hence the scaffold and appbar get ditched in favor of simple containers for any buttons we need, stacked atop the image.
I found that
layoutInsetscan be used to have the initial size of the image limited to the are that is not covered by buttons.Issue Being Fixed
The inability of the image to fill the screen in some circumstances, causing it to get cut off for seemingly no reason. This was especially prevalent in landscape aspect ratios.
Screenshots / Recordings
Kooha-2024-05-03-22-54-31.mp4
Checklist
semanticLabels where applicable for accessibility?