Initial restructure of image viewer, fixes some immedate bugs

.github/PULL_REQUEST_TEMPLATE.md

@@ -14,6 +14,6 @@ Issue Number: N/A
 
 ## Checklist
 
-- [ ] Did you update CHANGELOG.md?
-- [ ] Did you use localized strings where applicable?
+- [ ] If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
+- [ ] Did you use localized strings (and added appropriate descriptions) where applicable?
 - [ ] Did you add `semanticLabel`s where applicable for accessibility?

.github/workflows/ci.yml

@@ -14,11 +14,16 @@ jobs:
     name: Linting & Formatting
     runs-on: ubuntu-latest
     steps:
+      - name: Install libsqlite3
+        run: sudo apt-get -y install libsqlite3-0 libsqlite3-dev
+
       - uses: actions/checkout@v3
+        with:  
+          submodules: 'recursive'
 
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.19.x'
+          flutter-version: '3.24.x'
           channel: "stable"
           cache: true
           cache-key: 'flutter-:os:-:channel:-:version:-:arch:-:hash:' # optional, change this to force refresh cache
@@ -29,7 +34,7 @@ jobs:
         run: flutter pub get
 
       - name: Install arb_utils to check sorting of translations
-        run: dart pub global activate arb_utils 0.6.0 # temporarily force version 0.6.0 to fix build errors
+        run: dart pub global activate arb_utils
 
       - name: Copy translation file
         run: cp ./lib/l10n/app_en.arb ./lib/l10n/app_en_tmp.arb
@@ -52,7 +57,7 @@ jobs:
         run: flutter analyze --no-fatal-infos --no-fatal-warnings
 
       - name: Formatting
-        run: dart format --set-exit-if-changed -l 200 .
+        run: dart format -o none --set-exit-if-changed -l 200 lib
 
       - name: Tests
         run: flutter test

.gitignore

@@ -32,6 +32,7 @@ release/
 .pub-cache/
 .pub/
 /build/
+/debug/
 
 # Symbolication related
 app.*.symbols
@@ -43,6 +44,10 @@ app.*.map.json
 /android/app/debug
 /android/app/profile
 /android/app/release
+/android/build
+
+# IOS build
+/ios/build
 
 # Docker ignores
 key.properties

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "packages/push"]
+	path = packages/push
+	url = https://github.com/thunder-app/push.git

CHANGELOG.md

@@ -8,6 +8,7 @@
 - Setting to use colorized usernames - contribution from @ggichure.
 - Show the number of new comments a read post has received since last visited
 - Added ability to mark read on scroll - contribution from @Fmstrat
+- Added barebones support for video players. Youtube and video codecs - contribution from @ggichure.
 
 ## Changed
 - Small UI adjustments for account switcher

LICENSE

@@ -662,4 +662,5 @@ For more information on this, and how to apply and follow the GNU AGPL, see
 
 Portions of this software are copyright of their respective authors and released
 under the MIT license:
-- marquee_widget.dart, Copyright (c) 2018 Marcel Garus
+- marquee_widget.dart, Copyright (c) 2018 Marcel Garus
+- conditional_parent_widget.dart, Copyright (c) 2023 ltOgt

README.md

@@ -133,7 +133,7 @@ Contributions are always welcome, but please abide by our community [code of con
 
 To contribute potential features or bug-fixes:
 
-1. Fork this repository
+1. Fork this repository, and clone with submodules: `git clone --recurse-submodules -j8 [email protected]:thunder-app/thunder.git`
 2. Base the feature or fix off the `develop` branch. This is to allow for pre-release versions without affecting the main general releases.
 3. Apply any changes and/or additions based off an existing issue (or create a new issue for the feature/fix you are working on)
 4. Create a pull request to have your changes reviewed and merged
@@ -171,6 +171,16 @@ You can also run your local development environment for Android via the Docker c
 ./scripts/docker-dev-android.sh
 ```
 
+### Troubleshooting
+
+```shell
+Could not determine the dependencies of task ':unifiedpush_android:compileReleaseKotlin'.
+> Cannot find a Java installation on your machine matching this tasks requirements: {languageVersion=8, vendor=any, implementation=vendor-specific}
+   > No locally installed toolchains match and toolchain download repositories have not been configured.
+```
+
+Resolution: Ensure you have a valid Java 8 installation on your machine.
+
 ## Conventions
 
 While there are no specific conventions that must be followed, do try to follow best practices whenever possible.

analysis_options.yaml

@@ -8,6 +8,10 @@
 # The following line activates a set of recommended lints for Flutter apps,
 # packages, and plugins designed to encourage good coding practices.
 include: package:flutter_lints/flutter.yaml
+analyzer:
+  errors:
+    use_build_context_synchronously: ignore
+  exclude: [packages/**]
 
 linter:
   # The lint rules applied to this project can be customized in the

android/app/build.gradle

@@ -32,7 +32,7 @@ android {
     namespace "com.hjiangsu.thunder"
     // Use variable for version requested by background_fetch and flutter_local_notifications
     compileSdkVersion rootProject.ext.compileSdkVersion
-    ndkVersion flutter.ndkVersion
+    ndkVersion = "25.1.8937393"
 
     compileOptions {
         // The following line is required by flutter_local_notifications

android/app/proguard-rules.pro

@@ -29,4 +29,23 @@
 -keep,allowobfuscation,allowshrinking class com.google.gson.reflect.TypeToken
 -keep,allowobfuscation,allowshrinking class * extends com.google.gson.reflect.TypeToken
 
-##---------------End: proguard configuration for Gson  ----------
+##---------------End: proguard configuration for Gson  ----------
+
+##---------------Begin: proguard configuration for App Links  ----------
+# SPDX-FileCopyrightText: 2016, microG Project Team
+# SPDX-License-Identifier: CC0-1.0
+
+# Keep AutoSafeParcelables
+-keep public class * extends org.microg.safeparcel.AutoSafeParcelable {
+    @org.microg.safeparcel.SafeParcelable.Field *;
+    @org.microg.safeparcel.SafeParceled *;
+}
+
+# Keep asInterface method cause it's accessed from SafeParcel
+-keepattributes InnerClasses
+-keepclassmembers interface * extends android.os.IInterface {
+    public static class *;
+}
+-keep public class * extends android.os.Binder { public static *; }
+
+##---------------End: proguard configuration for App Links  ----------

android/app/src/main/AndroidManifest.xml

@@ -7,6 +7,7 @@
     <uses-permission android:name="android.permission.READ_MEDIA_IMAGES" />
     <uses-permission android:name="android.permission.READ_MEDIA_VIDEO" />
     <uses-permission android:name="android.permission.VIBRATE" />
+
     <!-- The tools:replace line is needed by background_fetch -->
     <!-- requestLegacyExternalStorage is required for saving media to an album in API 29 -->
     <application
@@ -25,7 +26,12 @@
             android:theme="@style/LaunchTheme"
             android:configChanges="orientation|keyboardHidden|keyboard|screenSize|smallestScreenSize|locale|layoutDirection|fontScale|screenLayout|density|uiMode"
             android:hardwareAccelerated="true"
+            android:resizeableActivity="true"
             android:windowSoftInputMode="adjustResize">
+            <!--Allowing support for multi windows (split-screen mode) & picture-in-picture mode -->
+            <meta-data android:name="android.allow_multiple_resumed_activities" android:value="true" />
+            <!--Disable Flutter's built-in deep linking -->
+            <meta-data android:name="flutter_deeplinking_enabled" android:value="false" />
             <!-- support sharing images -->
              <intent-filter
                  android:label="@string/create_post">
@@ -54,6 +60,12 @@
                 <action android:name="android.intent.action.MAIN"/>
                 <category android:name="android.intent.category.LAUNCHER"/>
             </intent-filter>
+            <intent-filter>
+                <action android:name="android.intent.action.VIEW" />
+                <category android:name="android.intent.category.DEFAULT" />
+                <category android:name="android.intent.category.BROWSABLE" />        
+                <data android:scheme="thunder"/>
+            </intent-filter>
             <intent-filter>
               <action android:name="android.intent.action.VIEW" />
               <category android:name="android.intent.category.DEFAULT" />
@@ -64,24 +76,25 @@
               <data android:host="aussie.zone" />
               <data android:host="awful.systems" />
               <data android:host="beehaw.org" />
-              <data android:host="burggit.moe" />
+              <data android:host="delraymisfitsboard.com" />
               <data android:host="discuss.online" />
               <data android:host="discuss.tchncs.de" />
               <data android:host="feddit.dk" />
               <data android:host="feddit.it" />
               <data android:host="feddit.nl" />
               <data android:host="feddit.nu" />
+              <data android:host="feddit.org" />
               <data android:host="feddit.uk" />
               <data android:host="hexbear.net" />
               <data android:host="infosec.pub" />
-              <data android:host="iusearchlinux.fyi" />
               <data android:host="jlai.lu" />
               <data android:host="lemdro.id" />
               <data android:host="leminal.space" />
               <data android:host="lemm.ee" />
               <data android:host="lemmings.world" />
               <data android:host="lemmy.blahaj.zone" />
               <data android:host="lemmy.ca" />
+              <data android:host="lemmy.cafe" />
               <data android:host="lemmy.dbzer0.com" />
               <data android:host="lemmy.eco.br" />
               <data android:host="lemmy.kya.moe" />
@@ -91,11 +104,11 @@
               <data android:host="lemmy.sdf.org" />
               <data android:host="lemmy.today" />
               <data android:host="lemmy.world" />
+              <data android:host="lemmy.wtf" />
               <data android:host="lemmy.zip" />
               <data android:host="lemmygrad.ml" />
               <data android:host="lemmynsfw.com" />
               <data android:host="lemy.lol" />
-              <data android:host="lululemmy.com" />
               <data android:host="mander.xyz" />
               <data android:host="midwest.social" />
               <data android:host="monero.town" />
@@ -109,7 +122,6 @@
               <data android:host="szmer.info" />
               <data android:host="thelemmy.club" />
               <data android:host="ttrpg.network" />
-              <data android:host="yiffit.net" />
               <!--#INSTANCE_LIST_END#-->
             </intent-filter>
         </activity>

devtools_options.yaml

@@ -0,0 +1 @@
+extensions:

drift_schemas/drift_schema_v1.json

@@ -0,0 +1 @@
+{"_meta":{"description":"This file contains a serialized version of schema entities for drift.","version":"1.1.0"},"options":{"store_date_time_values_as_text":false},"entities":[{"id":0,"references":[],"type":"table","data":{"name":"accounts","was_declared_in_moor":false,"columns":[{"name":"id","getter_name":"id","moor_type":"int","nullable":false,"customConstraints":null,"defaultConstraints":"PRIMARY KEY AUTOINCREMENT","default_dart":null,"default_client_dart":null,"dsl_features":["auto-increment"]},{"name":"username","getter_name":"username","moor_type":"string","nullable":true,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"jwt","getter_name":"jwt","moor_type":"string","nullable":true,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"instance","getter_name":"instance","moor_type":"string","nullable":true,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"anonymous","getter_name":"anonymous","moor_type":"bool","nullable":false,"customConstraints":null,"defaultConstraints":"CHECK (\"anonymous\" IN (0, 1))","default_dart":"const Constant(false)","default_client_dart":null,"dsl_features":[]},{"name":"user_id","getter_name":"userId","moor_type":"int","nullable":true,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]}],"is_virtual":false,"without_rowid":false,"constraints":[]}},{"id":1,"references":[],"type":"table","data":{"name":"favorites","was_declared_in_moor":false,"columns":[{"name":"id","getter_name":"id","moor_type":"int","nullable":false,"customConstraints":null,"defaultConstraints":"PRIMARY KEY AUTOINCREMENT","default_dart":null,"default_client_dart":null,"dsl_features":["auto-increment"]},{"name":"account_id","getter_name":"accountId","moor_type":"int","nullable":false,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"community_id","getter_name":"communityId","moor_type":"int","nullable":false,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]}],"is_virtual":false,"without_rowid":false,"constraints":[]}},{"id":2,"references":[],"type":"table","data":{"name":"local_subscriptions","was_declared_in_moor":false,"columns":[{"name":"id","getter_name":"id","moor_type":"int","nullable":false,"customConstraints":null,"defaultConstraints":"PRIMARY KEY AUTOINCREMENT","default_dart":null,"default_client_dart":null,"dsl_features":["auto-increment"]},{"name":"name","getter_name":"name","moor_type":"string","nullable":false,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"title","getter_name":"title","moor_type":"string","nullable":false,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"actor_id","getter_name":"actorId","moor_type":"string","nullable":false,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"icon","getter_name":"icon","moor_type":"string","nullable":true,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]}],"is_virtual":false,"without_rowid":false,"constraints":[]}}]}

drift_schemas/drift_schema_v2.json

@@ -0,0 +1 @@
+{"_meta":{"description":"This file contains a serialized version of schema entities for drift.","version":"1.1.0"},"options":{"store_date_time_values_as_text":false},"entities":[{"id":0,"references":[],"type":"table","data":{"name":"accounts","was_declared_in_moor":false,"columns":[{"name":"id","getter_name":"id","moor_type":"int","nullable":false,"customConstraints":null,"defaultConstraints":"PRIMARY KEY AUTOINCREMENT","default_dart":null,"default_client_dart":null,"dsl_features":["auto-increment"]},{"name":"username","getter_name":"username","moor_type":"string","nullable":true,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"jwt","getter_name":"jwt","moor_type":"string","nullable":true,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"instance","getter_name":"instance","moor_type":"string","nullable":true,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"anonymous","getter_name":"anonymous","moor_type":"bool","nullable":false,"customConstraints":null,"defaultConstraints":"CHECK (\"anonymous\" IN (0, 1))","default_dart":"const Constant(false)","default_client_dart":null,"dsl_features":[]},{"name":"user_id","getter_name":"userId","moor_type":"int","nullable":true,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]}],"is_virtual":false,"without_rowid":false,"constraints":[]}},{"id":1,"references":[],"type":"table","data":{"name":"favorites","was_declared_in_moor":false,"columns":[{"name":"id","getter_name":"id","moor_type":"int","nullable":false,"customConstraints":null,"defaultConstraints":"PRIMARY KEY AUTOINCREMENT","default_dart":null,"default_client_dart":null,"dsl_features":["auto-increment"]},{"name":"account_id","getter_name":"accountId","moor_type":"int","nullable":false,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"community_id","getter_name":"communityId","moor_type":"int","nullable":false,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]}],"is_virtual":false,"without_rowid":false,"constraints":[]}},{"id":2,"references":[],"type":"table","data":{"name":"local_subscriptions","was_declared_in_moor":false,"columns":[{"name":"id","getter_name":"id","moor_type":"int","nullable":false,"customConstraints":null,"defaultConstraints":"PRIMARY KEY AUTOINCREMENT","default_dart":null,"default_client_dart":null,"dsl_features":["auto-increment"]},{"name":"name","getter_name":"name","moor_type":"string","nullable":false,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"title","getter_name":"title","moor_type":"string","nullable":false,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"actor_id","getter_name":"actorId","moor_type":"string","nullable":false,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"icon","getter_name":"icon","moor_type":"string","nullable":true,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]}],"is_virtual":false,"without_rowid":false,"constraints":[]}},{"id":3,"references":[],"type":"table","data":{"name":"user_labels","was_declared_in_moor":false,"columns":[{"name":"id","getter_name":"id","moor_type":"int","nullable":false,"customConstraints":null,"defaultConstraints":"PRIMARY KEY AUTOINCREMENT","default_dart":null,"default_client_dart":null,"dsl_features":["auto-increment"]},{"name":"username","getter_name":"username","moor_type":"string","nullable":false,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]},{"name":"label","getter_name":"label","moor_type":"string","nullable":false,"customConstraints":null,"default_dart":null,"default_client_dart":null,"dsl_features":[]}],"is_virtual":false,"without_rowid":false,"constraints":[]}}]}