-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Try updating xbean-asm #199
base: tomee-1.7.x-TT.x-release
Are you sure you want to change the base?
Draft: Try updating xbean-asm #199
Conversation
pom.xml
Outdated
@@ -1636,6 +1636,10 @@ | |||
<groupId>commons-pool</groupId> | |||
<artifactId>commons-pool</artifactId> | |||
</exclusion> | |||
<exclusion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, these shaded jars change the relocated package so usages of org.apache.xbean.asm5
become org.apache.xbean.asm9
in the code. The version of OpenWebBeans in use in this version of TomEE still uses ASM5, so we'd either need to patch that version of OWB to use ASM9, or continue to use both (assuming that works).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version of OpenWebBeans in use in this version of TomEE still uses ASM5, so we'd either need to patch that version of OWB to use ASM9, or continue to use both (assuming that works).
yesterday I executed the test locally on one open-ejb related module from this PR and test passes, I guess I was lucky so I decided to move with CI for getting the full picture. But yes, the package in OWB changed :( .
test this please. |
test this please. |
We were getting inconsistencies between CI resuls for 1.7.6-TT.28 and this PR because the PR was based on OS 1.7.6 and not on 1.7.6-TT.28. The result for c65d683 would be the ones that we can compare between Before and After CI results. |
test this please. |
This PR gest +25 failures than tomee-1.7.x-TT.x-release branch. I see errors like:
So open-jpa 2.4.3 also brings xbean-asm6-shaded jars
So based on the above it seems we need to patch open-jpa 2.4.3 to use asm9 instead of asm6, release it and test again this PR bu using open-jpa 2.4.3-T.1. |
This attempts to upgrade the version of xbean-asm to a recent version to allow jars with module-info to be scanned. This version of TomEE is old, and so OWB still brings in an older version of xbean-asm, so jars with module-info may still fail.