Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Try updating xbean-asm #199

Draft
wants to merge 7 commits into
base: tomee-1.7.x-TT.x-release
Choose a base branch
from
Draft

Draft: Try updating xbean-asm #199

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2285e6f
Try updating xbean-asm
jgallimore Jun 7, 2022
2e937f2
Exclude xbean-asm5-shaded since xbean-asm9-shaded-4.21 is already pro…
cesarhernandezgt Jun 7, 2022
9568e84
Upgrade openwebbeans to 1.2.8-TT.1
cesarhernandezgt Jun 8, 2022
c65d683
Merge branch 'tomee-1.7.x-TT.x-release' into upgrade-xbean-asm
cesarhernandezgt Jun 9, 2022
9ec4ed7
fixed pom
cesarhernandezgt Jun 9, 2022
e540ce9
Upgraded to jpa 2.4.3-TT.1
cesarhernandezgt Jul 30, 2022
35e530e
upgraded to cxf 2.6.17-TT.9
cesarhernandezgt Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1636,6 +1636,10 @@
<groupId>commons-pool</groupId>
<artifactId>commons-pool</artifactId>
</exclusion>
<exclusion>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, these shaded jars change the relocated package so usages of org.apache.xbean.asm5 become org.apache.xbean.asm9 in the code. The version of OpenWebBeans in use in this version of TomEE still uses ASM5, so we'd either need to patch that version of OWB to use ASM9, or continue to use both (assuming that works).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of OpenWebBeans in use in this version of TomEE still uses ASM5, so we'd either need to patch that version of OWB to use ASM9, or continue to use both (assuming that works).

yesterday I executed the test locally on one open-ejb related module from this PR and test passes, I guess I was lucky so I decided to move with CI for getting the full picture. But yes, the package in OWB changed :( .

<groupId>org.apache.xbean</groupId>
<artifactId>xbean-asm5-shaded</artifactId>
</exclusion>

<!-- regarding maven rules, we don't need to exclude those deps
because we already depend on -->
Expand Down Expand Up @@ -1946,6 +1950,10 @@
<groupId>org.apache.xbean</groupId>
<artifactId>xbean-finder-shaded</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.xbean</groupId>
<artifactId>xbean-asm5-shaded</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
Expand Down