chore(suite): separate popup logic from @suite-common/connect-init
#15975
+186
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
|
This would fix the issue with suite-native dependency tree, but I'm not sure if this new package belongs to suite-common and I don't like the name that can be confused with @trezor/connect-popup. Is it intended to be reused on mobile in the future for mobile connect popup? I would move it to packages and rename to something like connect-popup-desktop? |
|
I see potential to reuse it for mobile as well, but it would need some adjustments. |
martykan
force-pushed
the
chore/separate-connect-init-desktop-popup
branch
from
9786cea to
39c0b79
Compare
martykan
force-pushed
the
chore/separate-connect-init-desktop-popup
branch
from
39c0b79 to
399d96e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate popup logic from
@suite-common/connect-initinto a new package@trezor/suite-desktop-connect-popup