Document Twig vs PHP types #4362
Conversation
fabpot
force-pushed
the
document-twig-types
branch
from
530480e to
66e8bce
Compare
|
I think this one is ready, comments are welcomed. |
fabpot
force-pushed
the
document-twig-types
branch
from
66e8bce to
ac47c88
Compare
|
Thanks for the heads up, Fabian. I'll have a look at this tomorrow or Wednesday and will provide feedback. |
fabpot
force-pushed
the
document-twig-types
branch
from
ac47c88 to
aa5467c
Compare
fabpot
force-pushed
the
document-twig-types
branch
from
aa5467c to
9690e7b
Compare
|
LGTM as well 👍 |
| Twig Type PHP Type | ||
| =================== =============================== | ||
| string A string or a Stringable object | ||
| number An integer or a float |
There was a problem hiding this comment.
In the docs int is used here: https://twig.symfony.com/doc/3.x/tags/types.html#types
Do we specify for the new feature PHP types instead of Twig types?
There was a problem hiding this comment.
Good catch!
While the documentation states "The syntax for and contents of type strings are intentionally left out of scope", I do agree that "number" and "boolean" are better choices to align with the documentation on types.
I'll create a PR for updating the types documentation.
Specifically, "bool" => "boolean" and "int" => "number". This aligns the `types` documentation with templates.rst. See twigphp#4362 Thanks, @alexander-schranz!
…nstead of PHP (drjayvee) This PR was squashed before being merged into the 3.x branch. Discussion ---------- Documentation for types tag uses Twig types in examples instead of PHP Specifically, "bool" => "boolean" and "int" => "number". This aligns the `types` documentation with templates.rst. See #4362 Thanks, `@alexander`-schranz! Commits ------- f3e0a00 Documentation for types tag uses Twig types in examples instead of PHP
Refs #4256