Documentation for types tag uses Twig types in examples instead of PHP #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, "bool" => "boolean" and "int" => "number". This aligns the `types` documentation with templates.rst. See twigphp#4362 Thanks, @alexander-schranz!
This comment was marked as resolved.
This comment was marked as resolved.
|
The documentation is not up to date. PHPStan does properly understand See https://phpstan.org/r/24895f82-975a-4e08-b7b1-5da29d058ddd |
|
Do you think it's worth it to update TypesTest.php and TypesTokenParser.php ? |
|
Thank you @drjayvee. |
fabpot
added a commit
that referenced
this pull request
Oct 23, 2024
…nstead of PHP (drjayvee) This PR was squashed before being merged into the 3.x branch. Discussion ---------- Documentation for types tag uses Twig types in examples instead of PHP Specifically, "bool" => "boolean" and "int" => "number". This aligns the `types` documentation with templates.rst. See #4362 Thanks, `@alexander`-schranz! Commits ------- f3e0a00 Documentation for types tag uses Twig types in examples instead of PHP
|
Not sure why Github doesn't understand this one was merged 🤷 |
|
@fabpot this happens when we squash commits but we are not allowed to push the squashed commits back to the branch from which the PR is submitted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, "bool" => "boolean" and "int" => "number".
This aligns the
typesdocumentation with templates.rst. See #4362Thanks, @alexander-schranz!