Remove mentions and workarounds for older Redis versions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkmkme
force-pushed
the
mkmkme/remove-old-valkey
branch
from
fbda826 to
7e077b9
Compare
Signed-off-by: Mikhail Koviazin <[email protected]>
`skip_if_server_version_gte` doesn't currently make sense as there's only one version of Valkey. All the tests that used that decorator refered to older versions that are not available. We'll keep the decorator itself for the future. Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
`NO_AUTH_SET_ERROR` used to be different for Redis < 6.0 and Redis >= 6.0. It's not applicable for Valkey, hence the obsolete snippet has been removed. Additionally, `test_connection_pool` for both sync and async versions have been fixed since they expected an obsolete string in the logs. Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
mkmkme
force-pushed
the
mkmkme/remove-old-valkey
branch
from
7e077b9 to
ebbc1d4
Compare
aiven-sal
approved these changes
May 29, 2024
6 tasks
aiven-sal
added a commit
that referenced
this pull request
Jun 12, 2024
Revert #8 and replace "redis" and "old valkey" with "server"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This batch removes the mentions and workarounds for older Redis versions.
Hopefully everything has been covered.
Fixes #5.