Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.5.61 #1704

Merged
merged 28 commits into from
May 1, 2024
Merged

2.5.61 #1704

merged 28 commits into from
May 1, 2024

Conversation

spond
Copy link
Member

@spond spond commented May 1, 2024

No description provided.

src/core/likefunc.cpp Fixed Show fixed Hide fixed
src/core/likefunc.cpp Dismissed Show dismissed Hide dismissed
Comment on lines +6722 to +6726
/*if (CheckEqual(gradL,0.0)) {
break;
} else {
gradient *= 1./gradL;
}
}*/

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
src/core/likefunc.cpp Dismissed Show dismissed Hide dismissed
Comment on lines +6501 to +6503
//if (verbosity_level > 150) {
//printf ("_LikelihoodFunction::ComputeGradient %ld\t%s\t @%20.18g\t f(x) = %20.18g, f(x+h) = %20.18g, delta(F) = %20.18g, h = %20.18g, correction = %20.18g, grad = %20.18g\n", index, GetIthIndependentName(index)->get_str(), currentValue, funcValue, dF, dF-funcValue, testStep, DerivativeCorrection (index, currentValue), gradient.theData[index]);
//}

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
src/core/tree_evaluator.cpp Dismissed Show dismissed Hide dismissed
Comment on lines +160 to +162
//if (siteID == 524) {
// fprintf (stderr, "Site-state @ %ld: %d\n", nodeCode, siteState);
//}

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +405 to +408
} /*else {
//ObjectToConsole(mapping);
printf ("%s => NOTHING\n", nodeName.get_str());
}*/

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
src/core/variable.cpp Dismissed Show dismissed Hide dismissed
Comment on lines +716 to +717
//_String * fs = (_String*)varFormula->toStr(kFormulaStringConversionNormal);
//NLToConsole(); StringToConsole(*fs); DeleteObject (fs);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9.3% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

if (!ith_dep->IsValueInBounds(dep_value)) {
ReportWarning (_String ("Failing bound checks on ") & *ith_dep->GetName() & " = " & _String (dep_value, "%25.16g"));
}
//printf ("\nSetting %s to %g\n", ith_dep->GetName()->get_str(), dep_value);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
for (long i = 0; i < compiled_constraints->formulasToEval.lLength; i++) {
compiled_constraints->formulaValues[i] = ((_Formula*)(compiled_constraints->formulasToEval.get (i)))->ComputeSimple(compiled_constraints->theStack, compiled_constraints->varValues);

//printf ("\nComputed formula %d to %g\n", i, compiled_constraints->formulaValues[i]);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
// populate all the independent variables
for (long i = 0; i < compiled_constraints->varIndex.lLength; i++) {
compiled_constraints->varValues[i].value = LocateVar(compiled_constraints->varIndex[i])->Value();
//printf ("\nArgument %s = %g\n", LocateVar(compiled_constraints->varIndex[i])->GetName()->get_str(), compiled_constraints->varValues[i].value);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@spond spond merged commit c668448 into master May 1, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant