Fixed some function names and sorted alphabetically #410
Conversation
|
I do not know this error |
|
because |
db.yml
Outdated
| ksceMsifDisableSlowMode: 0x75848756 | ||
| ksceMsifEnableSlowMode: 0x4B751CE6 | ||
| ksceMsifGetMsInfo: 0xD0307849 | ||
|
|
There was a problem hiding this comment.
these are original function before the patch.
so can you change other side?
and maybe give postfix(like 2~4) is better than prefix(_)
but if you think it's private function, just remain the comment :)
There was a problem hiding this comment.
I'm sorry but I can not figure out where to fix it.
Function names such as _sceErrorGetExternalString are defined in SceSysLibTrace.
There was a problem hiding this comment.
i mentioned c2a2ec7 commit parts, and you added same name function to other side.
imo, _ prefix only can have an internal function(private method)
btw technically we can call it if that was defined nid. :/
There was a problem hiding this comment.
No @d3m3vilurr there are _sce prefixed functions that are exported.
The issue is the ksce naming: it would give k_sce.
Moreover sometimes __sce.
There was a problem hiding this comment.
@CelesteBlue-dev I know. and you told repeat and repeat about objection of the vitasdk's decisions that why we use ksce instead ForDriver/Kernel and why we don't use the sony's export name.
please stop.
this project isn't the sony project, technically we would use reverse engineering, but we couldn't reference of the sony's official sdk.
it means, we can choose another name for nid which has more meaningful.
(but yeah, you couldn't agree it).
There was a problem hiding this comment.
so @CelesteBlue-dev you can suggest another name, and if that name has really good, we can change every name.
but it is also sdk, so full changing wouldn't be acceptable :)
…rmBridgeUser function name
|
this pr would break backward compatibility, but it seems move to right place. and I'll merge it manually, pr needs squashing some commits( |
|
merged 8fe91a2 |
|
I was worried to see a PR so huge (+7,555 −7,552) being merged |
This pull request introduced some breaking changes.
No description provided.