-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): add markdown content hooks #1620
Open
pengzhanbo
wants to merge
10
commits into
vuepress:main
Choose a base branch
from
pengzhanbo:on-content-updated
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+161
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12308970701Details
💛 - Coveralls |
Mister-Hope
previously approved these changes
Dec 6, 2024
uepress/docs also needs a PR |
|
meteorlxy
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e tests are required
pengzhanbo
changed the title
feat(client): add
feat(client): add markdown content hooks
Dec 12, 2024
onContentUpdated
hooks
@meteorlxy @Mister-Hope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
close #123
).What is the purpose of this pull request?
Description
When the markdown content changes, using the built-in Vue lifecycle hooks does not work well, so the
onContentMounted
/onContentChange
/onContentBeforeUnmount
hook has been added to properly listen for changes in the content.This applies to scenarios such as
medium-zoom
orphoto-swipe
that require reinitialization when the page content changes.