fix: panic when removing pubsub topic

[richard-ramos]

Description

Fixes this error:

panic: runtime error: slice bounds out of range [2:1]

goroutine 291 [running]:
github.com/waku-org/go-waku/waku/v2/peerstore.(*WakuPeerstoreImpl).RemovePubSubTopic(0xc000018b40, {0xc00088a360, 0x27}, {0x0?, 0x11?})
	/home/richard/waku-org/go-waku/waku/v2/peerstore/waku_peer_store.go:169 +0x1dc
github.com/waku-org/go-waku/waku/v2/peermanager.(*PeerManager).peerEventLoop(0xc0003f0c60, {0x26de4d0, 0xc00046e8c0})
	/home/richard/waku-org/go-waku/waku/v2/peermanager/peer_manager.go:109 +0x25c
created by github.com/waku-org/go-waku/waku/v2/peermanager.(*PeerManager).Start

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	7805dd6	#1	2023-09-20 23:16:48	~2 min	tests	📄log
✔️	7805dd6	#1	2023-09-20 23:16:57	~2 min	tests	📄log
✔️	7805dd6	#1	2023-09-20 23:17:18	~3 min	nix-flake	📄log
✔️	7805dd6	#1	2023-09-20 23:17:36	~3 min	linux	📦deb
✔️	7805dd6	#1	2023-09-20 23:17:58	~4 min	ios	📦tgz
✔️	7805dd6	#1	2023-09-20 23:18:14	~4 min	android	📦tgz
✔️	7805dd6	#2	2023-09-21 06:53:36	~55 sec	linux	📦deb
✔️	7805dd6	#2	2023-09-21 06:54:36	~2 min	nix-flake	📄log
✔️	7805dd6	#2	2023-09-21 06:55:08	~3 min	tests	📄log
✔️	7805dd6	#2	2023-09-21 06:56:13	~3 min	ios	📦tgz
✔️	7805dd6	#2	2023-09-21 06:56:30	~3 min	android	📦tgz
✖️	7805dd6	#2	2023-09-21 06:57:23	~6 min	tests	📄log
✔️	7805dd6	#3	2023-09-21 09:30:14	~1 min	tests	📄log

[chaitanyaprem]

LGTM

[chaitanyaprem]

@jakubgs Looks like jenkins execution result is not being picked back up by github.
https://ci.status.im/job/go-waku/job/prs/job/roid/job/PR-759/ shows as success.
Same for all jobs.

Could you please take a look?

[jakubgs]

That's weird:

Could not update commit status, please check if your scan credentials belong to a member of the organization or a collaborator of the repository and repo:status scope is selected

Seems like someone switched permissions to read-only for Bots, fixed them:

[chaitanyaprem]

That's weird:

Could not update commit status, please check if your scan credentials belong to a member of the organization or a collaborator of the repository and repo:status scope is selected

Seems like someone switched permissions to read-only for Bots, fixed them:

Hmm, alright. Might have been done by accident.
Let me put this out in the team channel so that people are careful while changing permissions.

Thanks a lot for the quick trurnaround!