Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deno and Node to extra implementers of various specs #35

Merged
merged 10 commits into from
Jan 24, 2022

Conversation

lucacasonato
Copy link
Member

See whatwg/streams#1141 for more background on this.

I have not added Deno to fetch even though we implement it, because most changes in there are really not relevant to us in the slightest (CORS etc).

factory.json Outdated Show resolved Hide resolved
factory.json Outdated Show resolved Hide resolved
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! Just a nit on the approach, but overall this seems fine and much appreciated.

factory.py Outdated Show resolved Hide resolved
factory.py Outdated Show resolved Hide resolved
factory.json Outdated Show resolved Hide resolved
Copy link

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 woo! thanks for doing this @lucacasonato

@lucacasonato
Copy link
Member Author

Talked to James, and have now added Node to the following specs:

  • Console
  • DOM (only for AbortController, AbortSignal, Event, and EventTarget)
  • Encoding
  • HTML (only for timers, structured clone, base64 utils, channel messaging)
  • Streams
  • URL

Deno has been added to the following specs:

  • Console
  • DOM (only for AbortController, AbortSignal, Event, and EventTarget)
  • Encoding
  • Fetch (not for CORS changes)
  • HTML (only for timers, structured clone, base64 utils, channel messaging, web workers, and web storage)
  • Streams
  • URL
  • WebIDL
  • WebSockets

@jasnell
Copy link

jasnell commented Jan 21, 2022

WebIDL would probably be a good one for Node.js also. We implement only in so far as it is relevant to the other specs but receiving notifications on changes there would be helpful.

@GeoffreyBooth
Copy link

For Node you could also add import assertions, and possibly ES modules generally.

@lucacasonato
Copy link
Member Author

ES modules are not specified here, but in TC39. Specific import assertions are not very relevant to Node I think, because Node likely won't implement most of the assertions specified other than JSON. (Same goes for Deno in this case).

@GeoffreyBooth
Copy link

Specific import assertions are not very relevant to Node I think, because Node likely won’t implement most of the assertions specified other than JSON. (Same goes for Deno in this case).

I was thinking of situations like this: whatwg/html#7342

@lucacasonato
Copy link
Member Author

@GeoffreyBooth Added "esm resolver" to node's and Deno's interest lists

factory.json Outdated Show resolved Hide resolved
@annevk annevk merged commit 7c36b2c into whatwg:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants