Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deno and Node to extra implementers of various specs #35

Merged
merged 10 commits into from
Jan 24, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PULL_REQUEST_TEMPLATE.md.template
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ Thank you for contributing to the @@h1@@ Standard! Please describe the change yo
- [ ] [Implementation bugs](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) are filed:
* Chrome: …
* Firefox: …
* Safari: …
* Safari: …@@extra_implementers@@

(See [WHATWG Working Mode: Changes](https://whatwg.org/working-mode#changes) for more details.)
33 changes: 28 additions & 5 deletions factory.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,49 @@
},
"console": {
"extra_files": "images/*.*",
"not_these_templates": [".editorconfig"]
"not_these_templates": [".editorconfig"],
"extra_implementers": ["Deno", "Node.js"]
},
"dom": {
"extra_implementers": [
"Deno (only for AbortController, AbortSignal, Event, and EventTarget)",
"Node.js (only for AbortController, AbortSignal, Event, and EventTarget)"
]
},
"encoding": {
"extra_files": "*.txt *.json *.css",
"post_build_step": "python visualize.py \"$$DIR/\"",
".gitignore": ["/UnicodeData.txt"]
".gitignore": ["/UnicodeData.txt"],
"extra_implementers": ["Deno", "Node.js"]
},
"fetch": {
"extra_implementers": ["Deno (not for CORS changes)"]
},
"html": {
"only_these_templates": ["LICENSE", "PULL_REQUEST_TEMPLATE.md"]
"only_these_templates": ["LICENSE", "PULL_REQUEST_TEMPLATE.md"],
"extra_implementers": [
"Deno (only for timers, structured clone, base64 utils, channel messaging, web workers, and web storage)",
"Node.js (only for timers, structured clone, base64 utils, channel messaging)"
]
},
"infra": {
"not_these_templates": ["PULL_REQUEST_TEMPLATE.md"]
},
"streams": {
"extra_files": "demos/* demos/**/*",
"not_these_templates": [".editorconfig"]
"not_these_templates": [".editorconfig"],
"extra_implementers": ["Deno", "Node.js"]
},
"url": {
"extra_implementers": ["Deno", "Node.js"]
},
"webidl": {
".gitignore": ["/node_modules/"],
"build_with_node": true,
"post_build_step": "node ./check-grammar.js \"$$DIR/index.html\" && npm run pp-webidl -- --input \"$$DIR/index.html\""
"post_build_step": "node ./check-grammar.js \"$$DIR/index.html\" && npm run pp-webidl -- --input \"$$DIR/index.html\"",
"extra_implementers": ["Deno"]
},
"websockets": {
"extra_implementers": ["Deno"]
}
}
6 changes: 4 additions & 2 deletions factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,11 @@ def fill_template(contents, variables):
for entry in data:
output += "\n{}".format(entry)
data = output
elif variable == "extra_implementers":
data = map(lambda name : "\n * " + name + ": …", data)
contents = contents.replace("@@{}@@".format(variable), data)
return contents


def update_files(shortname, name):
os.chdir("../{}".format(shortname))

Expand All @@ -82,7 +83,8 @@ def update_files(shortname, name):
"post_build_step": "",
".gitignore": [],
"only_these_templates": None,
"not_these_templates": None
"not_these_templates": None,
"extra_implementers": []
}
if shortname in FACTORY_DB:
variables.update(FACTORY_DB[shortname])
Expand Down