Fix the missing flow argument in TileLink/ToAXI4 #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`flow` must be explicitly passed to `Queue.irrevocable` to avoid mismatching the arguments.
jerryz123
approved these changes
Oct 7, 2023
poemonsense
added a commit
to OpenXiangShan/rocket-chip
that referenced
this pull request
Oct 7, 2023
`flow` must be explicitly passed to `Queue.irrevocable` to avoid mismatching the arguments.
This was referenced Oct 7, 2023
poemonsense
added a commit
to OpenXiangShan/rocket-chip
that referenced
this pull request
Oct 8, 2023
`flow` must be explicitly passed to `Queue.irrevocable` to avoid mismatching the arguments.
Tang-Haojin
pushed a commit
to OpenXiangShan/rocket-chip
that referenced
this pull request
Oct 8, 2023
`flow` must be explicitly passed to `Queue.irrevocable` to avoid mismatching the arguments.
Tang-Haojin
pushed a commit
to OpenXiangShan/rocket-chip
that referenced
this pull request
Oct 8, 2023
`flow` must be explicitly passed to `Queue.irrevocable` to avoid mismatching the arguments.
madhava-c
pushed a commit
to morphingmachines/rocket-chip
that referenced
this pull request
Feb 9, 2024
`flow` must be explicitly passed to `Queue.irrevocable` to avoid mismatching the arguments.
This was referenced Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flowmust be explicitly passed toQueue.irrevocableto avoid mismatching the arguments.Related issue: #3287
Type of change: bug report
Impact: API modification
Development Phase: implementation
Release Notes