New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl: define `OPENSSL_FOUND` in `CMakeDeps` generator #12838

Merged

conan-center-bot merged 2 commits into conan-io:master from SpaceIm:fix/openssl-cmakedeps-variable

Sep 6, 2022

Contributor

SpaceIm commented Sep 5, 2022 •

edited

Loading

OPENSSL_FOUND is not defined if find_package() consumes the config file from CMakeDeps (another side effect for conan-io/conan#10387). This PR fixes this issue by setting OPENSSL_FOUND to TRUE unconditionally.

I've seen this issue while trying to migrate mariadb-connector-c, its CMakeLists has a strong logic based on OPENSSL_FOUND, and it miserably fails if casing is wrong.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.


          define OPENSSL_FOUND in CMakeDeps also

c36235f

ghost mentioned this pull request

[service] Potentially conflicting recipes #3571

Closed

ghost commented Sep 5, 2022 •

edited by ghost

Loading

I detected other pull requests that are modifying openssl/1.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

This was referenced Sep 5, 2022

openssl - Annotate version required to run the tests #12827

Merged

openssl: Enable valid block of options for openssl >= 1.1.0 #11725

Closed

github-actions bot mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

SpaceIm force-pushed the fix/openssl-cmakedeps-variable branch from a1ec2d5 to 7b4f655 Compare

September 5, 2022 22:27

This comment has been minimized.

Sign in to view

conan-center-bot added Unexpected Error and removed Unexpected Error labels


          few more conan v2 tools to satisfy hooks

755a0c5

SpaceIm force-pushed the fix/openssl-cmakedeps-variable branch from 7b4f655 to 755a0c5 Compare

September 5, 2022 22:30

This comment has been minimized.

Sign in to view

conan-center-bot added Unexpected Error and removed Unexpected Error labels

This was referenced Sep 5, 2022

mariadb-connector-c: conan v2 support #12839

Merged

bzip2: fix BZIP2_FOUND in CMakeDeps #12840

Merged

Contributor Author

SpaceIm commented Sep 5, 2022 •

edited

Loading

FYI, several recipes should be fixed the same way:
bzip2
freetype
jasper
libgeotiff
libxml2
openal
xz_utils

If they are not fixed, any recipe migrating to CMakeToolchain and depending on one of these libraries may fail (or worse, silently disable a feature and not honor an option).

Collaborator

conan-center-bot commented Sep 6, 2022

All green in build 4 (755a0c5bda7871bde2372619d053e3cb4e712dc6):

openssl/1.1.1q@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment, tools
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

openssl/1.1.0l@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment, tools
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

openssl/1.1.1p@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment, tools
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

openssl/3.0.5@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12838/recipes/openssl/3.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12838/recipes/openssl/3.x.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12838/recipes/openssl/3.x.x/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment, tools
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

openssl/1.1.1o@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment, tools
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

openssl/1.0.2u@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12838/recipes/openssl/1.x.x/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment, tools
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

openssl/3.0.4@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12838/recipes/openssl/3.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12838/recipes/openssl/3.x.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12838/recipes/openssl/3.x.x/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment, tools
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

openssl/3.0.3@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12838/recipes/openssl/3.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12838/recipes/openssl/3.x.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12838/recipes/openssl/3.x.x/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment, tools
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

uilianries approved these changes

View reviewed changes

Member

uilianries left a comment

LGTM

jgsogo approved these changes

View reviewed changes

ghost mentioned this pull request

openssl: Make debug build renaming optional #10939

Closed

4 tasks

conan-center-bot merged commit a0a72a3 into conan-io:master

SpaceIm deleted the fix/openssl-cmakedeps-variable branch

September 6, 2022 13:16

SpaceIm mentioned this pull request

[bug] Properly define custom <LIB>_FOUND in CMakeDeps generators of several recipes #12954

Open

ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request


          (conan-io#12838) openssl: define OPENSSL_FOUND in CMakeDeps gener…

32a841a

…ator

* define OPENSSL_FOUND in CMakeDeps also

* few more conan v2 tools to satisfy hooks

This was referenced Oct 14, 2022

poco: conan v2 support #12868

Merged

[package] poco/1.12.2: JWT tries to link Poco::Crypto but it can't be found #13577

Closed

jngrb added a commit to jngrb/conan-center-index that referenced this pull request


          [openssl 3.x.x] fix "official" OpenSSL vars for CMakeDeps gen

b51d60a

this extends the improvements of PR conan-io#12838 done for the 1.x.x recipe
to the 3.x.x one; also there is a new 3.x.x test_package using
the CMakeDeps generator

jngrb mentioned this pull request

[openssl 3.x.x] fix "official" OpenSSL vars for CMakeDeps gen #14426

Closed

4 tasks

jngrb mentioned this pull request

[bug] OPENSSL_FOUND and similar variables aren't defined conan-io/conan#10829

Closed

jngrb added a commit to jngrb/conan-center-index that referenced this pull request


          [openssl 3.x.x] fix "official" OpenSSL vars for CMakeDeps gen

8dc7267

this extends the improvements of PR conan-io#12838 done for the 1.x.x recipe
to the 3.x.x one; also there is a new 3.x.x test_package using
the CMakeDeps generator

jngrb added a commit to jngrb/conan-center-index that referenced this pull request


          [openssl 3.x.x] fix "official" OpenSSL vars for CMakeDeps gen

0397aeb

this extends the improvements of PR conan-io#12838 done for the 1.x.x recipe
to the 3.x.x one; also there is a new 3.x.x test_package using
the CMakeDeps generator

jngrb mentioned this pull request

Openssl 3.x.x conan v2 #16563

Closed

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet