Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "do not reply to this automated message" copy to remaining emails, fix X logo location, swap Twitter for X on other automated email templates #24506

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Dec 6, 2024

For consistency with new MFA email in #22078.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.52%. Comparing base (d37b658) to head (53ff3fa).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #24506   +/-   ##
=======================================
  Coverage   63.52%   63.52%           
=======================================
  Files        1591     1591           
  Lines      151131   151133    +2     
  Branches     3845     3847    +2     
=======================================
+ Hits        96000    96014   +14     
+ Misses      47485    47473   -12     
  Partials     7646     7646           
Flag Coverage Δ
frontend 53.66% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iansltx iansltx changed the title Add "do not reply to this automated message" copy to remaining emails Add "do not reply to this automated message" copy to remaining emails, fix X logo location, swap Twitter for X on other automated email templates Dec 6, 2024
@iansltx
Copy link
Member Author

iansltx commented Dec 6, 2024

Screenshots below. Logo fix will happen once this is merged to main.

SMTP Setup

SMTP setup email template screenshot

Confirm Email Change

Confirm email change email template screenshot

Password Reset

Password reset email template screenshot

Invite

Invite email template screenshot

@iansltx iansltx marked this pull request as ready for review December 6, 2024 23:12
@iansltx iansltx requested a review from a team as a code owner December 6, 2024 23:12
@fleet-release fleet-release requested a review from eashaw December 6, 2024 23:12
Copy link
Member

@RachelElysia RachelElysia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@sharon-fdm sharon-fdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iansltx iansltx merged commit c474843 into main Dec 9, 2024
12 checks passed
@iansltx iansltx deleted the add-unmonitored-email-verbiage branch December 9, 2024 15:19
iansltx added a commit that referenced this pull request Dec 9, 2024
…, fix X logo location, swap Twitter for X on other automated email templates (#24506)

For consistency with new MFA email in #22078.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
iansltx added a commit that referenced this pull request Dec 9, 2024
…aining emails, fix X logo location, swap Twitter for X on other automated email templates (#24528)

For consistency with new MFA email in #22078. Merged into `main` via
#24506.
@jmwatts
Copy link
Member

jmwatts commented Dec 10, 2024

QA Note:
Confirmed font has been updated for:

  • SMTP setup confirmed
  • Confirm your updated email address
  • Reset your Fleet password
  • You have been invited to Fleet

Example old font:
Old_SMTP_Conf.png

Example new font:
New_SMTP_Conf.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants