Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gzrt to v0.9.1 #7241

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Update gzrt to v0.9.1 #7241

wants to merge 27 commits into from

Conversation

mazzalab
Copy link
Contributor

@mazzalab mazzalab commented Dec 18, 2024

  • Update module to use the latest, patched, version of gzrt (0.8 -> 0.9.1)
  • Fixed naming convention
  • Controlled in/out names collision

PR checklist

Closes #7240

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@mazzalab mazzalab self-assigned this Dec 18, 2024
@mazzalab mazzalab added WIP Work in progress update module labels Dec 18, 2024
GallVp
GallVp previously approved these changes Dec 18, 2024
@GallVp
Copy link
Member

GallVp commented Dec 18, 2024

Looks good!

@mazzalab
Copy link
Contributor Author

I am waiting for bioconda to publish the artifacts (that were packaged this night but are not available yet in biocontainers)

@mazzalab
Copy link
Contributor Author

Hi @GallVp, I've just updated the biocontainer URL, and it should be working now, but cannot test here because tests do not start

@mazzalab mazzalab enabled auto-merge December 19, 2024 14:02
@mazzalab mazzalab removed the WIP Work in progress label Dec 19, 2024
@mazzalab mazzalab added WIP Work in progress and removed Ready for Review labels Dec 19, 2024
@mazzalab
Copy link
Contributor Author

@GallVp I've updated the module.

Since CI seems not to work, I provide here a proof that tests actually pass, as discussed with @jfy133 in this thread: https://nfcore.slack.com/archives/CJRH30T6V/p1734872568537229?thread_ts=1734616829.020499&cid=CJRH30T6V

image

@mazzalab mazzalab added Ready for Review and removed WIP Work in progress labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update module: GZRT
3 participants