refactor: refactor source executor (part 2) #15104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
9 tasks
xxchan
changed the title
xxchan
commented
Feb 18, 2024
Comment on lines
-181
to
-183
| if states.is_empty() { | ||
| // TODO should be a clear Error Code | ||
| bail!("states require not null"); |
There was a problem hiding this comment.
I don't find this check useful?
There was a problem hiding this comment.
it is ok to remove the check, no need any more
xxchan
commented
Feb 18, 2024
Comment on lines
-311
to
-332
| if let Some(target_splits) = target_state { | ||
| let target_split_ids: HashSet<_> = | ||
| target_splits.iter().map(|split| split.id()).collect(); | ||
|
|
||
| cache.retain(|split| target_split_ids.contains(&split.id())); | ||
|
|
||
| let dropped_splits = core | ||
| .latest_split_info | ||
| .extract_if(|split_id, _| !target_split_ids.contains(split_id)) | ||
| .map(|(_, split)| split) | ||
| .collect_vec(); | ||
|
|
||
| if should_trim_state && !dropped_splits.is_empty() { | ||
| // trim dropped splits' state | ||
| core.split_state_store.trim_state(&dropped_splits).await?; | ||
| } | ||
|
|
||
| core.latest_split_info = target_splits | ||
| .into_iter() | ||
| .map(|split| (split.id(), split)) | ||
| .collect(); | ||
| } |
There was a problem hiding this comment.
This section is moved to update_state_if_changed now
|
Oops, deterministic test failed |
xxchan
commented
Feb 18, 2024
| // existing split, no change, clone from cache | ||
| target_state.push(s.clone()) | ||
| for (split_id, split) in target_splits { | ||
| if let Some(s) = core.latest_split_info.get(&split_id) { |
There was a problem hiding this comment.
This line is a minor change. I think using latest_split_info is better than updated_splits_in_epoch here.
This was referenced Feb 18, 2024
Base automatically changed from
02-16-refactor_refactor_SourceExecutor
to
main
February 19, 2024 05:46
xxchan
force-pushed
the
02-18-refactor_refactor_source_executor
branch
from
d42f9c7 to
6975649
Compare
TennyZhuang
added a commit
that referenced
this pull request
Feb 21, 2024
This reverts commit 2592880.
TennyZhuang
added a commit
that referenced
this pull request
Feb 21, 2024
This reverts commit 2592880.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This refactor reduces the
target_statevariable passed around. It's hard to understand and error-prone since we already have the fields have similar meanings.We update the states immediately instead.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.