Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(risedev): add some configs for monitoring #15354

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Feb 29, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Support changing prometheus scrape-interval and tempo max_bytes_per_trace for some extreme cases.
Also increase grpc message size limit in case tempo trace too large.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented Feb 29, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

@xxchan xxchan force-pushed the 01-02-feat_add_kafka_backfill_frontend branch from df5eb2d to 59bb3b7 Compare March 1, 2024 05:22
@xxchan xxchan force-pushed the 02-28-feat_risedev_add_some_configs_for_monitoring branch from 05ba150 to 4251f71 Compare March 1, 2024 05:22
@xxchan xxchan force-pushed the 01-02-feat_add_kafka_backfill_frontend branch from 59bb3b7 to 8e3c736 Compare March 5, 2024 06:53
@xxchan xxchan force-pushed the 02-28-feat_risedev_add_some_configs_for_monitoring branch from 4251f71 to 373b46a Compare March 5, 2024 06:55
@xxchan xxchan changed the base branch from 01-02-feat_add_kafka_backfill_frontend to main March 5, 2024 06:56
@xxchan xxchan requested a review from BugenZhao March 5, 2024 06:58
@xxchan xxchan marked this pull request as ready for review March 5, 2024 06:58
@xxchan
Copy link
Member Author

xxchan commented Mar 11, 2024

ping @BugenZhao 💦💦

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

risedev.yml Show resolved Hide resolved
@xxchan xxchan enabled auto-merge March 11, 2024 07:12
@xxchan xxchan added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit 525164b Mar 11, 2024
26 of 28 checks passed
@xxchan xxchan deleted the 02-28-feat_risedev_add_some_configs_for_monitoring branch March 11, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants