-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(risedev): add some configs for monitoring #15354
Merged
xxchan
merged 2 commits into
main
from
02-28-feat_risedev_add_some_configs_for_monitoring
Mar 11, 2024
Merged
feat(risedev): add some configs for monitoring #15354
xxchan
merged 2 commits into
main
from
02-28-feat_risedev_add_some_configs_for_monitoring
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 29, 2024
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
xxchan
force-pushed
the
01-02-feat_add_kafka_backfill_frontend
branch
from
March 1, 2024 05:22
df5eb2d
to
59bb3b7
Compare
xxchan
force-pushed
the
02-28-feat_risedev_add_some_configs_for_monitoring
branch
from
March 1, 2024 05:22
05ba150
to
4251f71
Compare
xxchan
force-pushed
the
01-02-feat_add_kafka_backfill_frontend
branch
from
March 5, 2024 06:53
59bb3b7
to
8e3c736
Compare
xxchan
force-pushed
the
02-28-feat_risedev_add_some_configs_for_monitoring
branch
from
March 5, 2024 06:55
4251f71
to
373b46a
Compare
xxchan
changed the base branch from
01-02-feat_add_kafka_backfill_frontend
to
main
March 5, 2024 06:56
ping @BugenZhao 💦💦 |
BugenZhao
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Support changing prometheus
scrape-interval
and tempomax_bytes_per_trace
for some extreme cases.Also increase grpc message size limit in case tempo trace too large.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.