Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce v1beta1 api #647

Merged
merged 6 commits into from
Feb 23, 2019
Merged

Introduce v1beta1 api #647

merged 6 commits into from
Feb 23, 2019

Conversation

hossainemruz
Copy link
Contributor

@hossainemruz hossainemruz commented Jan 15, 2019 •
edited
Loading

xref: #648

@hossainemruz hossainemruz mentioned this pull request Jan 15, 2019
Closed
@codecov-io
Copy link

codecov-io commented Jan 15, 2019 •
edited
Loading

Codecov Report

Merging #647 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #647   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines           7      8    +1     
=====================================
+ Hits            7      8    +1
Impacted Files Coverage Δ
apis/stash/install/install.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf4469...f9e58aa. Read the comment docs.

tamalsaha
tamalsaha reviewed Feb 6, 2019
View reviewed changes
docs/design.md Outdated Show resolved Hide resolved
tamalsaha
tamalsaha reviewed Feb 6, 2019
View reviewed changes
docs/design.md Outdated Show resolved Hide resolved
@tamalsaha
Copy link
Member

tamalsaha commented Feb 6, 2019 •
edited
Loading

  1. Let's call this stash/v1beta1
  2. Don't reuse any names from stash/v1alpha1 api.
  3. This will allow users to run Stash:0.9.0 & stash/v1beta1 operators in the same cluster. Our master branch will have docs for stash/v1beta1 only.
  4. stash/v1beta1 will be graduate to stash/v1 as-is assuming we get the api right.
  5. stash/v1alpha1 will be grandfathered with restic 0.8.3 .
Function == Action
Task / Activity / StashTemplate / ActionSequence -> []Function

BackupConfigurationTemplate <-- for default backups
BackupConfiguration
BackupSession -> 1:M(restic snapshots)
--------------

RestoreSession
- `restore: Always` will be an annotation on workload
  1. Stash CLI (kubectl plugin)
    Use cases:
    6a. Restore into local disk: wrapper around restic cli.
    6b. Restore into a different namespace from a repository: copy repository + secret into the desired namespace and then create RestoreSession object.
    6c. Backup PV: creates matching PVC from PV (ensures that user has permission to read PV).

tamalsaha
tamalsaha reviewed Feb 6, 2019
View reviewed changes
docs/design.md Outdated Show resolved Hide resolved
tamalsaha
tamalsaha reviewed Feb 6, 2019
View reviewed changes
docs/design.md Outdated Show resolved Hide resolved
tamalsaha
tamalsaha reviewed Feb 6, 2019
View reviewed changes
docs/design.md Outdated Show resolved Hide resolved
tamalsaha
tamalsaha reviewed Feb 6, 2019
View reviewed changes
docs/design.md Outdated Show resolved Hide resolved
tamalsaha
tamalsaha reviewed Feb 6, 2019
View reviewed changes
docs/design.md Outdated Show resolved Hide resolved
tamalsaha
tamalsaha reviewed Feb 6, 2019
View reviewed changes
docs/design.md Outdated Show resolved Hide resolved
tamalsaha
tamalsaha reviewed Feb 6, 2019
View reviewed changes
docs/design.md Outdated Show resolved Hide resolved
tamalsaha
tamalsaha reviewed Feb 6, 2019
View reviewed changes
docs/design.md Outdated Show resolved Hide resolved
tamalsaha
tamalsaha reviewed Feb 6, 2019
View reviewed changes
docs/design.md Outdated
apiVersion: stash.appscode.com/v1alpha2
kind: DefaultBackupConfiguration
metadata:
name: default-volume-backup-configuration
Copy link
Member

@tamalsaha tamalsaha Feb 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example:
name: gitlab-backup-config

@tamalsaha tamalsaha mentioned this pull request Feb 6, 2019
Closed
@tamalsaha tamalsaha changed the title Add v1alpha2 api Introduce v1beta1 api Feb 8, 2019
@tamalsaha tamalsaha mentioned this pull request Feb 12, 2019
Closed
@tamalsaha
Copy link
Member

tamalsaha commented Feb 12, 2019 •
edited
Loading

  • [?] SecurityScheme

  • [?] ExecutionEnvironment

  • AutoRestore should be based on annotation on workload.

diptadas
diptadas suggested changes Feb 14, 2019
View reviewed changes
apis/stash/v1beta1/task_types.go Outdated Show resolved Hide resolved
apis/stash/v1beta1/function_types.go Outdated Show resolved Hide resolved
apis/stash/v1beta1/task_types.go Outdated Show resolved Hide resolved
apis/stash/v1beta1/task_types.go Outdated Show resolved Hide resolved
apis/stash/v1beta1/types.go Outdated Show resolved Hide resolved
diptadas
diptadas suggested changes Feb 14, 2019
View reviewed changes
apis/stash/v1beta1/function_types.go Outdated Show resolved Hide resolved
This was referenced Feb 20, 2019
Merged
Merged
@tamalsaha tamalsaha merged commit 302311a into master Feb 23, 2019
@tamalsaha tamalsaha deleted the v1alpha2 branch February 23, 2019 17:41
tamalsaha pushed a commit that referenced this pull request Mar 19, 2019
@hossainemruz @tamalsaha
Add restic wrapper library (#673)
6a74602 
**Requirements:**
- [x] Merge #647 to master
- [x] Rebase against master
tamalsaha pushed a commit that referenced this pull request Mar 20, 2019
@tamalsaha
Resolve tasks for backup/restore sessions (#674)
7bdf075 
- [x] Merge #647 
- [x] Merge #673 

**Notes**

- Implicit inputs are collected from backup/restore session, backup config and repositories. For current list see `inputs.go`.
- Inputs to tasks are carried over to functions.
- Inputs for resolving tasks: implicit inputs + backup config params
- Inputs for resolving functions: inputs to parent task + task params
- Host name: `host-0`
- `drone/envsubst` only works with alphanumeric characters and underscore as key name.
tamalsaha pushed a commit that referenced this pull request Mar 21, 2019
@hossainemruz @tamalsaha
Update workload controller for new design (#675)
83f1c6e 
**Requirements:**
- [x] Merge #647 to master
- [x] Merge #673 to master
- [x] Merge #674 to master
- [x] Merge #671 to master
- [x] Rebase against master

**Tasks:**
- [x] Update Restore Logic
- [x] Update Backup Logic
- [x] Update Workload Controllers
	- [x] Deployment
	- [x] DaemonSet
	- [x] ReplicationControler
	- [x] ReplicaSet
	- [x] StatefulSet
- [x] Fix ConfigMap lock deletion and RBAC stuff deletion logic
- [x] Ensure sidecar/init-container according to new design
	- [x] Ensure Restore init-container injection
	- [x] Ensure Restore init-container deletion
	- [x] Ensure Backup sidecar injection
	- [x] Ensure Backup sidecar deletion
- [x] Add new backup command (sagor is working)
- [x] Add new restore command

- [x] Add controller (possibly in different PR)
	- [x] PersistentVolumeClaim
	- [x] AppBinding
This was referenced Mar 28, 2019
Closed
Closed
tamalsaha pushed a commit to stashed/postgres that referenced this pull request May 23, 2019
@hossainemruz @tamalsaha
Update workload controller for new design (#675)
cacbc7d 
**Requirements:**
- [x] Merge stashed/stash#647 to master
- [x] Merge stashed/stash#673 to master
- [x] Merge stashed/stash#674 to master
- [x] Merge stashed/stash#671 to master
- [x] Rebase against master

**Tasks:**
- [x] Update Restore Logic
- [x] Update Backup Logic
- [x] Update Workload Controllers
	- [x] Deployment
	- [x] DaemonSet
	- [x] ReplicationControler
	- [x] ReplicaSet
	- [x] StatefulSet
- [x] Fix ConfigMap lock deletion and RBAC stuff deletion logic
- [x] Ensure sidecar/init-container according to new design
	- [x] Ensure Restore init-container injection
	- [x] Ensure Restore init-container deletion
	- [x] Ensure Backup sidecar injection
	- [x] Ensure Backup sidecar deletion
- [x] Add new backup command (sagor is working)
- [x] Add new restore command

- [x] Add controller (possibly in different PR)
	- [x] PersistentVolumeClaim
	- [x] AppBinding
tamalsaha pushed a commit to stashed/docs that referenced this pull request May 25, 2019
@hossainemruz @tamalsaha
Update workload controller for new design (#675)
e51f5e5 
**Requirements:**
- [x] Merge stashed/stash#647 to master
- [x] Merge stashed/stash#673 to master
- [x] Merge stashed/stash#674 to master
- [x] Merge stashed/stash#671 to master
- [x] Rebase against master

**Tasks:**
- [x] Update Restore Logic
- [x] Update Backup Logic
- [x] Update Workload Controllers
	- [x] Deployment
	- [x] DaemonSet
	- [x] ReplicationControler
	- [x] ReplicaSet
	- [x] StatefulSet
- [x] Fix ConfigMap lock deletion and RBAC stuff deletion logic
- [x] Ensure sidecar/init-container according to new design
	- [x] Ensure Restore init-container injection
	- [x] Ensure Restore init-container deletion
	- [x] Ensure Backup sidecar injection
	- [x] Ensure Backup sidecar deletion
- [x] Add new backup command (sagor is working)
- [x] Add new restore command

- [x] Add controller (possibly in different PR)
	- [x] PersistentVolumeClaim
	- [x] AppBinding
tamalsaha pushed a commit to stashed/installer that referenced this pull request May 25, 2019
@hossainemruz @tamalsaha
Update workload controller for new design (#675)
02a4033 
**Requirements:**
- [x] Merge stashed/stash#647 to master
- [x] Merge stashed/stash#673 to master
- [x] Merge stashed/stash#674 to master
- [x] Merge stashed/stash#671 to master
- [x] Rebase against master

**Tasks:**
- [x] Update Restore Logic
- [x] Update Backup Logic
- [x] Update Workload Controllers
	- [x] Deployment
	- [x] DaemonSet
	- [x] ReplicationControler
	- [x] ReplicaSet
	- [x] StatefulSet
- [x] Fix ConfigMap lock deletion and RBAC stuff deletion logic
- [x] Ensure sidecar/init-container according to new design
	- [x] Ensure Restore init-container injection
	- [x] Ensure Restore init-container deletion
	- [x] Ensure Backup sidecar injection
	- [x] Ensure Backup sidecar deletion
- [x] Add new backup command (sagor is working)
- [x] Add new restore command

- [x] Add controller (possibly in different PR)
	- [x] PersistentVolumeClaim
	- [x] AppBinding
tamalsaha pushed a commit to stashed/installer that referenced this pull request May 25, 2019
@hossainemruz @tamalsaha
Update workload controller for new design (#675)
a1564dd 
**Requirements:**
- [x] Merge stashed/stash#647 to master
- [x] Merge stashed/stash#673 to master
- [x] Merge stashed/stash#674 to master
- [x] Merge stashed/stash#671 to master
- [x] Rebase against master

**Tasks:**
- [x] Update Restore Logic
- [x] Update Backup Logic
- [x] Update Workload Controllers
	- [x] Deployment
	- [x] DaemonSet
	- [x] ReplicationControler
	- [x] ReplicaSet
	- [x] StatefulSet
- [x] Fix ConfigMap lock deletion and RBAC stuff deletion logic
- [x] Ensure sidecar/init-container according to new design
	- [x] Ensure Restore init-container injection
	- [x] Ensure Restore init-container deletion
	- [x] Ensure Backup sidecar injection
	- [x] Ensure Backup sidecar deletion
- [x] Add new backup command (sagor is working)
- [x] Add new restore command

- [x] Add controller (possibly in different PR)
	- [x] PersistentVolumeClaim
	- [x] AppBinding
tamalsaha pushed a commit to stashed/installer that referenced this pull request May 27, 2019
@hossainemruz @tamalsaha
Update workload controller for new design (#675)
8c019a2 
**Requirements:**
- [x] Merge stashed/stash#647 to master
- [x] Merge stashed/stash#673 to master
- [x] Merge stashed/stash#674 to master
- [x] Merge stashed/stash#671 to master
- [x] Rebase against master

**Tasks:**
- [x] Update Restore Logic
- [x] Update Backup Logic
- [x] Update Workload Controllers
	- [x] Deployment
	- [x] DaemonSet
	- [x] ReplicationControler
	- [x] ReplicaSet
	- [x] StatefulSet
- [x] Fix ConfigMap lock deletion and RBAC stuff deletion logic
- [x] Ensure sidecar/init-container according to new design
	- [x] Ensure Restore init-container injection
	- [x] Ensure Restore init-container deletion
	- [x] Ensure Backup sidecar injection
	- [x] Ensure Backup sidecar deletion
- [x] Add new backup command (sagor is working)
- [x] Add new restore command

- [x] Add controller (possibly in different PR)
	- [x] PersistentVolumeClaim
	- [x] AppBinding
tamalsaha pushed a commit to stashed/apimachinery that referenced this pull request Feb 16, 2020
@hossainemruz @tamalsaha
Add restic wrapper library (#673)
2d5e2a4 
**Requirements:**
- [x] Merge stashed/stash#647 to master
- [x] Rebase against master
tamalsaha pushed a commit to stashed/apimachinery that referenced this pull request Feb 16, 2020
@hossainemruz @tamalsaha
Update workload controller for new design (#675)
886adaa 
**Requirements:**
- [x] Merge stashed/stash#647 to master
- [x] Merge stashed/stash#673 to master
- [x] Merge stashed/stash#674 to master
- [x] Merge stashed/stash#671 to master
- [x] Rebase against master

**Tasks:**
- [x] Update Restore Logic
- [x] Update Backup Logic
- [x] Update Workload Controllers
	- [x] Deployment
	- [x] DaemonSet
	- [x] ReplicationControler
	- [x] ReplicaSet
	- [x] StatefulSet
- [x] Fix ConfigMap lock deletion and RBAC stuff deletion logic
- [x] Ensure sidecar/init-container according to new design
	- [x] Ensure Restore init-container injection
	- [x] Ensure Restore init-container deletion
	- [x] Ensure Backup sidecar injection
	- [x] Ensure Backup sidecar deletion
- [x] Add new backup command (sagor is working)
- [x] Add new restore command

- [x] Add controller (possibly in different PR)
	- [x] PersistentVolumeClaim
	- [x] AppBinding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptadas diptadas diptadas requested changes

@tamalsaha tamalsaha tamalsaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hossainemruz @codecov-io @tamalsaha @diptadas