ML-KEM/Kyber: fix kyber_prf() for when no AVX2 #8306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no AVX2 available, kyber_prf() is called to produce more than one SHAKE-256 blocks worth of ouput. Otherwise only one block is needed. Changed function to support an outlen of greater than one block.
kp-thomas-yau
added a commit
to expressvpn/lightway-core
that referenced
this pull request
Dec 20, 2024
The patch is from: wolfSSL/wolfssl#8306 This patch fixes an issue where older CPUs, with no AVX2 support, fail to handshake Kyber/ML-KEM.
8 tasks
JacobBarthelmeh
approved these changes
Dec 20, 2024
kp-thomas-yau
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Dec 24, 2024
The patch is from: wolfSSL/wolfssl#8306 This patch fixes an issue where older CPUs, with no AVX2 support, fail to handshake Kyber/ML-KEM.
kp-thomas-yau
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Dec 24, 2024
The patch is from: wolfSSL/wolfssl#8306 This patch fixes an issue where older CPUs, with no AVX2 support, fail to handshake Kyber/ML-KEM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When no AVX2 available, kyber_prf() is called to produce more than one SHAKE-256 blocks worth of ouput. Otherwise only one block is needed. Changed function to support an outlen of greater than one block.
Fixes zd#19125
Testing
./configure --disable-shared --enable-kyber=all,original,ml-kem --enable-intelasm
Disable support for AVX2 in CPU detection.
./wolfcypt/test/testwolfcrypt
KYBER test failed!
Checklist